-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decimation option for adjoint solver #1722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 13 13
Lines 4535 4539 +4
=======================================
+ Hits 3328 3331 +3
- Misses 1207 1208 +1
|
stevengj
approved these changes
Aug 7, 2021
smartalecH
reviewed
Aug 10, 2021
smartalecH
approved these changes
Aug 10, 2021
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* decimation option for adjoint solver * fixes * more fixes * decimation option for EigenmodeCoefficient, FourierFields, Near2FarFields * add decimation to unit tests in test_adjoint_solver.py
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* decimation option for adjoint solver * fixes * more fixes * decimation option for EigenmodeCoefficient, FourierFields, Near2FarFields * add decimation to unit tests in test_adjoint_solver.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1684 and #1720, this PR adds a new
decimation_factor
parameter (default value of 1, i.e. no decimation) to theOptimizationProblem
and objective functionsEigenmodeCoefficient
,FourierFields
,Near2FarFields
of the adjoint solver to enable decimation of the DFT time-series updates. Since the entire design region is a DFT monitor for each of the Ex, Ey, Ez fields in 3d used in both the forward and adjoint runs, decimation of the time series can significantly reduce the cost of the DFT fields updates during adjoint optimization.